Add no-store to the Cache-Control header on auth responses #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
requested review from
donaldgray,
tomcrane and
frank-kerrigan
donaldgray
reviewed
Nov 14, 2024
There was a problem hiding this comment.
As the issue that we encountered is related to the AccessTokenResponse - is it worth adding tests to confirm the appropriate headings are set there? Would pick up if the attribute was somehow removed
src/protagonist/Orchestrator.Tests/Integration/AuthHandlingTests.cs
Outdated
Show resolved
Hide resolved
src/protagonist/Orchestrator.Tests/Integration/AuthHandlingTests.cs
Outdated
Show resolved
Hide resolved
…ilure + more checks on tests
JackLewis-digirati
changed the title
|
Btw, |
|
should be changed to use just |
JackLewis-digirati
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #833
This PR adds a
Cache-Controlheader ofno-cache,no-storeto the following endpoints:auth/{customer}/clickthroughauth/{customer}/tokenauth/{customer}/{authService}auth/{customer}/{authService}/logoutThis should help to avoid issues where auth responses are cached incorrectly
NOTE: this header has not been added to
auth/v2/probe/{customer}/{space}/{image}as this resource already has aCache-Controlvalue ofprivate